Re: [PATCH 3/3 v2] Implement completion limiting

[Gary Benson <gbenson at redhat dot com>]

Eli Zaretskii wrote:
> > From: Gary Benson <gbenson@redhat.com>
> > Date: Thu,  6 Nov 2014 10:50:46 +0000
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> 
> OK for this part.
> 
> > +void
> > +_initialize_completer (void)
> > +{
> > +  add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class,
> > +				       &max_completions, _("\
> > +Set maximum number of line completion possibilities."), _("\
> > +Show maximum number of line completion possibilities."), _("\
> 
> I suggest to use "completion candidates" instead of "line completion
> possibilities".
> 
> > +Use this to limit the number of possibilities considered\n\
> > +during line completion.  Specifying \"unlimited\" or -1\n\
>           ^^^^^^^^^^^^^^^
> And here use just "completion".  "Line completion" is IMO confusing,
> since we don't complete "lines".
> 
> > +@table @code
> > +@kindex set max-completions
> > +@item set max-completions @var{limit}
> > +@itemx set max-completions unlimited
> > +Set the maximum number of possibilities to be considered during
>                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> "Candidates to be shown" is better.
> 
> > +completion.  The default value is 200.  Note that setting either
> > +no limit or a very large limit can cause pauses during completion.
> 
> Not "cause pauses", but rather "make completion slow", I think.
> 
> > +@kindex show max-completions
> > +@item show max-completions
> > +Show the maximum number of possibilities to be considered during
> > +completion.
> 
> Suggest the same change here as above.
> 
> The documentation part of the patch is OK with those changes.
> 
> Thanks.

Thanks Eli.

Cheers,
Gary

-- 
http://gbenson.net/