This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/9] Rewrite lookup_static_symbol to use gdbarch routine
- From: Doug Evans <xdje42 at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sun, 16 Nov 2014 13:53:56 -0800
- Subject: Re: [PATCH 7/9] Rewrite lookup_static_symbol to use gdbarch routine
- Authentication-results: sourceware.org; auth=none
- References: <m3tx2qjee1 dot fsf at sspiff dot org> <87d29cvqfu dot fsf at codesourcery dot com> <m3389xbdk5 dot fsf at sspiff dot org> <m3a9439y60 dot fsf at sspiff dot org> <m361er9drc dot fsf at sspiff dot org> <m31tpd32xx dot fsf at sspiff dot org> <87y4rfjm9h dot fsf at codesourcery dot com> <CAP9bCMQEbfjt2N+qgzt-NXh27T+Gsa7i8cOCfoZ28EL-jfTbmA at mail dot gmail dot com> <m3lhncz5fi dot fsf at sspiff dot org> <20141116032213 dot GF5774 at adacore dot com>
On Sat, Nov 15, 2014 at 7:22 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hi Doug,
>
>> To keep things moving along I added the copyright headers.
>
> Thanks for doing that.
>
>> However, I think we could be a bit more lax when it comes to
>> such trivial testcases.
>
> The FSF allows us to be lax for trivial files (with 10 lines being
> one explicit limit on triviality). But:
>
> The problem with being lax is that it creates a little extra work
> for us at the start of each year, when we update the copyright headers.
> The FSF has been asking us to look into copyright headers in the past,
> and it was a lot of work, so I've added a bit of simple-minded code
> to the script that updates the copyright headers in GDB to also issue
> a warning if a copyright header hasn't been found. That way, we can
> then investigate the few problematic files each year rather than
> a massive number when the FSF notices something.
>
> That's why I always appreciate the copyright headers being added
> right from the start.
>
> So, again, thanks a lot for adding those! :)
No worries.
A few more words added to the wiki to added the needed context and
clarity would be great.
I'll do that.