Re: [PATCH 0/3] Fix fallout from GDB testsuite cleanup, fix more compiler warnings

[Doug Evans <xdje42 at gmail dot com>]

On Fri, Nov 14, 2014 at 10:47 AM, Andreas Arnez
<arnez@linux.vnet.ibm.com> wrote:
> It seems that my earlier testsuite cleanup has left some test cases in
> a broken state.  The first two patches fix (at least some of) these.
> I'm sorry for the breakage and hope that I didn't miss anything else.
>
> The third patch fixes some more compiler warnings I've overlooked
> before.
>
> Andreas Arnez (3):
>   Drop remaining references to removed source lines in break1.c and
>     ur1.c
>   Eliminate literal line numbers in mi-until.exp
>   GDB testsuite: More fixes for warnings with -std=gnu11
>
>  gdb/testsuite/gdb.base/bp-permanent.c        |  1 +
>  gdb/testsuite/gdb.base/condbreak.exp         | 28 ++++++++++++----------------
>  gdb/testsuite/gdb.base/ena-dis-br.exp        | 26 +++++++++++---------------
>  gdb/testsuite/gdb.base/hbreak2.exp           | 25 ++++++++-----------------
>  gdb/testsuite/gdb.mi/mi-until.exp            | 23 +++++++++++++++--------
>  gdb/testsuite/gdb.mi/until.c                 | 10 +++++-----
>  gdb/testsuite/gdb.python/py-framefilter-mi.c |  3 ++-
>  gdb/testsuite/gdb.python/py-framefilter.c    |  3 ++-
>  gdb/testsuite/gdb.reverse/until-precsave.exp |  6 +++---
>  gdb/testsuite/gdb.reverse/until-reverse.exp  |  6 +++---
>  gdb/testsuite/gdb.trace/actions-changed.c    |  3 +++
>  11 files changed, 65 insertions(+), 69 deletions(-)

Hi.

This patch set is ok.
Please commit ASAP. :-)

No worries on the breakage ... live and learn ...
And besides, thanks very much for taking this on!

btw,
the following violates the coding standards.
We're trying to be follow them more closely in the testsuite.
I don't mind it, but you might as well fix them.
[function result type goes on a line by itself]

diff --git a/gdb/testsuite/gdb.python/py-framefilter-mi.c
b/gdb/testsuite/gdb.python/py-framefilter-mi.c
index 242efa1..2955b71 100644
--- a/gdb/testsuite/gdb.python/py-framefilter-mi.c
+++ b/gdb/testsuite/gdb.python/py-framefilter-mi.c
@@ -132,7 +132,8 @@ int func5(int f, int d)
   return i;
 }

-main()
+int main()
 {
   func5(3,5);
+  return 0;
 }
diff --git a/gdb/testsuite/gdb.python/py-framefilter.c
b/gdb/testsuite/gdb.python/py-framefilter.c
index 80087c2..3102dda 100644
--- a/gdb/testsuite/gdb.python/py-framefilter.c
+++ b/gdb/testsuite/gdb.python/py-framefilter.c
@@ -146,10 +146,11 @@ int func5(int f, int d)
   return i;
 }

-main()
+int main()
 {
   int z = 32;
   int y = 44;
   const char *foo1 = "Test";
   func5(3,5);
+  return 0;
 }