This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V3 7/9] Simple testsuite for DTrace USDT probes.


Man, huge script!  I'm not going to pretend I read it.  :-P

On 10/28/2014 01:50 PM, Jose E. Marchesi wrote:
> +# This script uses the following external programs: tr, nm, egrep,
> +# sed, cut, readelf, sort, expr, wc, uniq, head, seq, as, strip, true

Hmm, looks like this invokes the system's readelf and strip.
I think we should be running the "transformed" tool name,
like e.g. x86_64-unknown-linux-gnu-strip, etc. ?

In configure.ac we do:

 `echo strip | sed -e "$transform"`

In tcl, we do

 set strip_to_file_program [transform strip]

Maybe we can make the script pick STRIP and READELF from the
environment, though I don't think that'd work for remote host
testing.  Otherwise, what is usually done is run the script
through configure.  That is, name it lib/pdtrace.in, and make
the testsuite's configure.ac generate the final pdtrace from that,
substituting @STRIP@ and @READELF@.  Like gdb/gcore.in.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]