Re: RFA: info macro [-at LOCATION,]

[Eli Zaretskii <eliz at gnu dot org>]

> cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Tue, 11 Nov 2014 09:01:15 -0500
> From: David Taylor <dtaylor@usendtaylorx2l.lss.emc.com>
> 
> > Thanks.  I think this warrants a NEWS entry as well.
> 
> Thanks.  How are diffs for NEWS handled?

Like any other file you modify.

> For the text, how about:
> 
> * New options
> 
> The info macro command now takes an optional location ([-at LOCATION,])
> for determining which definition, if any, of the macro is in scope.  If
> left unspecified it, as before, uses the source and line associated with
> the current program counter.

Fine with me, thanks.

> > > 	* gdb.texinfo: Document new -at LOCATION option of the 'info
> > > 	macro' command.
> > 
> > Please state the node in which the change was made (as if it were a
> > function, i.e. in parentheses).
> 
> Okay, how about:
> 
> 2014-11-10  David Taylor  <dtaylor@emc.com>
> 
> 	* gdb.texinfo (Macros): Document new -at LOCATION option of
> 	the 'info macro' command.

OK.

> > And second, "it is used instead of the current location" leaves too
> > much unsaid.  The reader will wonder why does location matter for this
> > purpose.  I suggest to make that explicit in the text.
> 
> I'm not sure how to word it nor exactly what you are looking for.
> How about the following for the gdb/doc/gdb.texinfo piece:

Sounds good to me.

> Thanks for reviewing the doc changes so quickly.

Thanks for working on this in the first place.