This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 08/13 v2] Rename gdbserver's low-level Linux x86 debug register accessors
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 28 Oct 2014 12:58:48 +0000
- Subject: Re: [PATCH 08/13 v2] Rename gdbserver's low-level Linux x86 debug register accessors
- Authentication-results: sourceware.org; auth=none
- References: <1412848358-9958-1-git-send-email-gbenson at redhat dot com> <1412848358-9958-9-git-send-email-gbenson at redhat dot com>
On 10/09/2014 10:52 AM, Gary Benson wrote:
> This commit renames gdbserver's low-level Linux x86 debug register
> accessors to the same names used by GDB.
>
> gdb/gdbserver/ChangeLog:
>
> * linux-x86-low.c (x86_dr_low_set_addr): Renamed as...
> (x86_linux_dr_set_addr): New function.
> (x86_dr_low_get_addr): Renamed as...
> (x86_linux_dr_get_addr): New function.
> (x86_dr_low_set_control): Renamed as...
> (x86_linux_dr_set_control): New function.
> (x86_dr_low_get_control): Renamed as...
> (x86_linux_dr_get_control): New function.
> (x86_dr_low_get_status): Renamed as...
> (x86_linux_dr_get_status): New function.
> (x86_dr_low): Updated with new function names.
This "New function" confuses me, as these are not new functions.
Would you mind changing this to (I think) the usual way to write
a rename:
* linux-x86-low.c (x86_dr_low_set_addr): Rename to ...
(x86_linux_dr_set_addr): ... this.
Also please s/renamed/rename/, s/updated/update/, etc., in this
and other patches.
Otherwise OK.
Thanks,
Pedro Alves