This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/2] Close the file in fileio.exp test
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Wed, 22 Oct 2014 13:43:36 +0800
- Subject: [PATCH 1/2] Close the file in fileio.exp test
- Authentication-results: sourceware.org; auth=none
- References: <1413956617-3979-1-git-send-email-yao at codesourcery dot com>
I see the following fail in fileio.exp on mingw32 host gdb,
rename 1: ret = -1, errno = 13^M
^M
Breakpoint 2, stop () at fileio.c:76^M
76 static void stop () {}^M
(gdb) FAIL: gdb.base/fileio.exp: Rename a file
the test fails to rename a file which is not expected. The previous
test test_write doesn't close the file, so the rename fails as a
result on Windows. This patch fixes it by closing file in test_write,
and the fail goes away.
rename 1: ret = 0, errno = 0 OK^M
^M
Breakpoint 2, stop () at fileio.c:76^M
76 static void stop () {}^M
(gdb) PASS: gdb.base/fileio.exp: Rename a file
gdb/testsuite:
2014-10-22 Yao Qi <yao@codesourcery.com>
* gdb.base/fileio.c (test_write): Close the file.
---
gdb/testsuite/gdb.base/fileio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
index b8c2698..29c32e0 100644
--- a/gdb/testsuite/gdb.base/fileio.c
+++ b/gdb/testsuite/gdb.base/fileio.c
@@ -169,6 +169,7 @@ test_write ()
ret = write (fd, STRING, strlen (STRING));
printf ("write 3: ret = %d, errno = %d %s\n", ret, errno,
strerrno (errno));
+ close (fd);
}
else
printf ("write 3: ret = %d, errno = %d\n", ret, errno);
--
1.9.3