This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/7] Fixes for aarch64-linux core file support
- From: Yao Qi <yao at codesourcery dot com>
- To: Omair Javaid <omair dot javaid at linaro dot org>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 21 Oct 2014 21:24:46 +0800
- Subject: Re: [PATCH 2/7] Fixes for aarch64-linux core file support
- Authentication-results: sourceware.org; auth=none
- References: <CANW4E-0xQ0mHfHN1UsXXjL7knxfdot=of8PzBghyVmvZ7xiU-g at mail dot gmail dot com> <1409233743-26944-1-git-send-email-omair dot javaid at linaro dot org>
Omair Javaid <omair.javaid@linaro.org> writes:
> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> /* Enable longjmp. */
> tdep->jb_pc = 11;
>
> + /* Install supported register note sections. */
> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
> +
> set_gdbarch_regset_from_core_section (gdbarch,
> aarch64_linux_regset_from_core_section);
Is this patch stale? I don't see the definition of
set_gdbarch_core_regset_sections. On the other hand, I see
aarch64-linux-tdep.c already has:
/* Implement the "regset_from_core_section" gdbarch method. */
static void
aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
iterate_over_regset_sections_cb *cb,
void *cb_data,
const struct regcache *regcache)
{
cb (".reg", AARCH64_LINUX_SIZEOF_GREGSET, &aarch64_linux_gregset,
NULL, cb_data);
cb (".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, &aarch64_linux_fpregset,
NULL, cb_data);
}
...
set_gdbarch_iterate_over_regset_sections
(gdbarch, aarch64_linux_iterate_over_regset_sections);
I assume this patch is no longer needed.
--
Yao (éå)