This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] ARM: extract_arm_insn function need to read instrs correctly in be8 case
- From: Yao Qi <yao at codesourcery dot com>
- To: Victor Kamensky <victor dot kamensky at linaro dot org>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 21 Oct 2014 15:54:53 +0800
- Subject: Re: [PATCH 2/5] ARM: extract_arm_insn function need to read instrs correctly in be8 case
- Authentication-results: sourceware.org; auth=none
- References: <1413853021-4393-1-git-send-email-victor dot kamensky at linaro dot org> <1413853021-4393-3-git-send-email-victor dot kamensky at linaro dot org>
Victor Kamensky <victor.kamensky@linaro.org> writes:
> Fix is to change gdbarch_byte_order to gdbarch_byte_order_for_code,
> when passed to extract_unsigned_integer that reads instruction.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/arm-tdep.c | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index c967a93..2aef5dc 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2014-10-13 Victor Kamensky <victor.kamensky@linaro.org>
> +
> + * arm-tdep.c (extract_arm_insn): use dbarch_byte_order_for_code
> + to read arm instruction.
> +
> 2014-09-30 Don Breazeal <donb@codesourcery.com>
>
> * inf-ptrace.c (inf_ptrace_follow_fork): Remove target-independent
Looks good to me.
We don't include the ChangeLog changes in the patch, because that will
cause conflicts when applying your patch locally in the review.
Instead, we include ChangeLog entries in the commit messages, see
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages
--
Yao (éå)