This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2 6/9] Support for DTrace USDT probes in x86_64 targets.
- From: Pedro Alves <palves at redhat dot com>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 17 Oct 2014 13:42:45 +0100
- Subject: Re: [PATCH V2 6/9] Support for DTrace USDT probes in x86_64 targets.
- Authentication-results: sourceware.org; auth=none
- References: <1412961772-16249-1-git-send-email-jose dot marchesi at oracle dot com> <1412961772-16249-7-git-send-email-jose dot marchesi at oracle dot com> <544041A7 dot 50802 at gmail dot com> <874mv2yime dot fsf at oracle dot com>
On 10/17/2014 01:40 PM, Jose E. Marchesi wrote:
>
> Hi Pedro.
>
> Thanks for your suggestions. I updated the patch addressing them.
>
Thanks, looks good. I'm left wondering about the Solaris
question though. :-)
Just a minor detail I missed first time around:
> --- a/gdb/amd64-linux-tdep.c
> +++ b/gdb/amd64-linux-tdep.c
> @@ -28,6 +28,8 @@
> #include "gdbtypes.h"
> #include "reggroups.h"
> #include "regset.h"
> +#include "parser-defs.h"
> +#include "user-regs.h"
Please also mention these include in the CL, like:
* amd64-linux-tdep.c: Include "parser-defs.h" and "user-regs.h".
(amd64_dtrace_parse_probe_argument): New function.
...
Thanks,
Pedro Alves