This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial


On Tue, Oct 14, 2014 at 2:01 PM, Doug Evans <dje@google.com> wrote:
> It'd be really nice to include a reference to the spec here.
> I don't know about others, but this stuff is not the kind of
> thing I tend to keep in cache, and when reading such code
> it's really nice to be able to find the relevant sections
> of the spec without any effort.
>
> Does the following make sense?
>
> +  /* A dynamic class has a non-trivial copy constructor.
> +     See c++98 section 12.8 Copying class objects [class.copy].  */
> +  if (gnuv3_dynamic_class (type))
> +    return 1;
> +

Thanks Doug. I will push this patch set after adding the above comment.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]