This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch] Microblaze: Port of Linux gdbserver



-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com] 
Sent: Monday, October 13, 2014 11:20 PM
To: Ajit Kumar Agarwal; Michael Eager; Pedro Alves; Joel Brobecker
Cc: gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch] Microblaze: Port of Linux gdbserver

On 10/13/14 09:00, Ajit Kumar Agarwal wrote:
>

>> +#define microblaze_breakpoint_len 4
>>
>>>> Use CAPS for macros.
>>
>> The MIPS and the ARM gdbserver code does not use the CAPS for the above macro defined.
>
>> Let's follow the GNU coding standard, even if some other targets haven't.
>
> https://gcc.gnu.org/ml/gcc-patches/2000-09/msg00901.html
> https://gcc.gnu.org/ml/gcc-patches/2000-09/msg00912.html

>To quote your first reference:

>"I actually think it's a mistake to spell function-like macros in ALL_CAPS, precisely because that makes changing back-and-forth unduly disruptive."

>To quote the second reference:

>"ALL_CAPS in cases when it's important to be aware that it's a macro, but when we make "wrappers" for efficiency purposes where we basically want to >pretend it's a function,".

>This is not a function-like macro.  In this case, it is important to be aware that this is a macro, not a variable.

The macro microblaze_breakpoint_len is initialized in the struct linux_target_ops the_low_target.  This makes it as a wrapper and the above quote is valid.  
Still the CAPS is required for the above macro? 

AGAIN, please follow the GNU Coding Standard.

Thanks & Regards
Ajit
-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]