This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] MIPS: Ignore invalid regs during info registers all
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>, James Hogan <james dot hogan at imgtec dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 3 Oct 2014 17:32:03 +0100
- Subject: Re: [PATCH] MIPS: Ignore invalid regs during info registers all
- Authentication-results: sourceware.org; auth=none
- References: <1412088186-26402-1-git-send-email-james dot hogan at imgtec dot com> <542AC5A9 dot 7060101 at redhat dot com> <542AC6CE dot 3070700 at imgtec dot com> <542ACDDB dot 2080202 at redhat dot com>
On Tue, 30 Sep 2014, Pedro Alves wrote:
> >>> The "info registers all" command causes mips_print_registers_info () to be
> >>> called for all register numbers, including invalid ones such as unused DSP
> >>> register numbers. This triggers an error () call which prevents further
> >>> register values being printed. Just silently return without printing
> >>> anything or erroring, so that all valid registers can be printed.
> >>
> >> What happens when the user does "info registers that-unused-register" ?
> >
> > I don't think that's possible, because the check is:
> > if (*(gdbarch_register_name (gdbarch, regnum)) == '\0')
> >
> > So any such register already has no name by which to refer to it.
>
> Indeed. :-) I'll leave it to Maciej to approve.
I didn't know `info registers' (and `info all-registers' presumably as
well) supported further arguments; I'll experiment with the patch a bit
and see what comes out.
James, did you push your change through regression testing? If so, then
how? Please always state precisely how changes you submit have been
validated.
Maciej