This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"


On 2014-09-24 02:53 PM, Sergio Durigan Junior wrote:
>> @@ -385,7 +386,7 @@ maintenance_info_program_spaces_command (char *args, int from_tty)
>>  	error (_("program space ID %d not known."), requested);
>>      }
>>  
>> -  print_program_space (current_uiout, requested);
>> +  print_program_space (current_uiout, requested, 0 /* prune */);
> 
> Just like we had a comment explaining why we were pruning progspaces, I
> think a small comment here explaining why we are *not* pruning them
> would be neat.

Sure, I could add to the current patch, above the call to print_program_space:

  /* Since this is an "info" command, we want to avoid modifying
     the state of the debugger. Therefore, don't prune unused
     program spaces. */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]