This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: James Clarke <jrtc27 at jrtc27 dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 15 Sep 2014 17:35:54 -0400
- Subject: Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
- Authentication-results: sourceware.org; auth=none
- References: <1410816254-24831-1-git-send-email-jrtc27 at jrtc27 dot com>
On Monday, September 15 2014, James Clarke wrote:
> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
> non-standard. Instead, `darwin-nat.c' should be using the standard
> `setjmp.h' header.
Thanks.
I am not a Mac user, and I know nothing about the details of the system,
but I did a little investigation and I think this is the right fix
indeed.
FWIW, I found
<https://lists.macosforge.org/pipermail/macports-tickets/2014-June/163911.html>
which is a related discussion.
This is not an approval, BTW.
> gdb/ChangeLog:
>
> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>
> PR gdb/17046
> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
> machine/setjmp.h header that no longer exists as of OS X 10.10.
> ---
> gdb/darwin-nat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
> index af4ec01..e550785 100644
> --- a/gdb/darwin-nat.c
> +++ b/gdb/darwin-nat.c
> @@ -42,7 +42,7 @@
>
> #include <sys/ptrace.h>
> #include <sys/signal.h>
> -#include <machine/setjmp.h>
> +#include <setjmp.h>
> #include <sys/types.h>
> #include <unistd.h>
> #include <signal.h>
> --
> 2.1.0
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/