This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack.
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Adrian Sendroiu <adrian dot sendroiu at freescale dot com>, tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 08 Sep 2014 14:59:38 -0400
- Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack.
- Authentication-results: sourceware.org; auth=none
- References: <53D8DA80 dot 8010603 at redhat dot com> <1406819332-24242-1-git-send-email-adrian dot sendroiu at freescale dot com> <53DA6D73 dot 5050906 at redhat dot com> <53E0E251 dot 7040803 at freescale dot com> <540DACE2 dot 9060400 at redhat dot com>
On Monday, September 08 2014, Pedro Alves wrote:
>> + mi_expect_stop "breakpoint-hit" "do_nothing" ".*" ".*" ".*" {".*" ".*"} "Continue to breakpoint"
>> +
>> + # This will crash gdb if redirection is not done properly.
>> + mi_gdb_test "help" ".*" "nested redirect"
>
> I think it'd be good to replace this ".*" with a stricter match, just
> in case something goes wrong with undoing the redirection, but nothing
> crashes. Something like (untested):
>
> mi_gdb_test "help" "List of classes of commands.*\\^done.*" "nested redirect"
I've been seeing some cases like this in the list (i.e., writing tests
using ".*" a lot). Maybe this is a good thing to mention in our wiki...
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/