This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack.
- From: Pedro Alves <palves at redhat dot com>
- To: Adrian Sendroiu <adrian dot sendroiu at freescale dot com>
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 08 Sep 2014 14:19:30 +0100
- Subject: Re: [PATCH v2 2/2] mi-out: Implement mi redirection using a stack.
- Authentication-results: sourceware.org; auth=none
- References: <53D8DA80 dot 8010603 at redhat dot com> <1406819332-24242-1-git-send-email-adrian dot sendroiu at freescale dot com> <53DA6D73 dot 5050906 at redhat dot com> <53E0E251 dot 7040803 at freescale dot com>
On 08/05/2014 02:55 PM, Adrian Sendroiu wrote:
> There's also the 1/2 patch from the series that needs to be applied
> before this.
>
> https://sourceware.org/ml/gdb-patches/2014-07/msg00574.html
Ah. Silly me, completely missed that. The test indeed passes cleanly
for me with that applied.
> + mi_expect_stop "breakpoint-hit" "do_nothing" ".*" ".*" ".*" {".*" ".*"} "Continue to breakpoint"
> +
> + # This will crash gdb if redirection is not done properly.
> + mi_gdb_test "help" ".*" "nested redirect"
I think it'd be good to replace this ".*" with a stricter match, just
in case something goes wrong with undoing the redirection, but nothing
crashes. Something like (untested):
mi_gdb_test "help" "List of classes of commands.*\\^done.*" "nested redirect"
This is OK with a change along those lines.
Thanks!
Pedro Alves