This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR fortran/17237: bug in f-valprint.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 3 Sep 2014 08:28:35 +0200
- Subject: Re: [PATCH] Fix PR fortran/17237: bug in f-valprint.c
- Authentication-results: sourceware.org; auth=none
- References: <1409680902-22975-1-git-send-email-sergiodj at redhat dot com>
> gdb/ChangeLog:
> 2014-09-02 Sergio Durigan Junior <sergiodj@redhat.com>
>
> PR fortran/17237
> * f-valprint.c (f_val_print): Specify the correct print option to
> use when printing integer values.
>
> gdb/testsuite/ChangeLog:
> 2014-09-02 Sergio Durigan Junior <sergiodj@redhat.com>
>
> PR fortran/17237
> * gdb.fortran/print-formatted.exp: New file.
> * gdb.fortran/print-formatted.f90: Likewise.
OK!
One minor suggestion:
> +gdb_test "print ii" " = 0xa" "print ii"
You don't really need the second "print ii" in the call to gdb_test,
I think. By default, the name of the test is the same as the test
itself. OK with me either way.
--
Joel