This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 05/11 v5] Add target/target.h
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Doug Evans <dje at google dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 20 Aug 2014 14:38:16 +0100
- Subject: Re: [PATCH 05/11 v5] Add target/target.h
- Authentication-results: sourceware.org; auth=none
- References: <1406888377-25795-1-git-send-email-gbenson at redhat dot com> <1406888377-25795-6-git-send-email-gbenson at redhat dot com> <53F48E22 dot 6010202 at redhat dot com>
Pedro Alves wrote:
> I worry about the fragmentation that moving pieces of target
> interfaces to target/target.h generates ends up confusing
> people. Did you consider leaving a marker in place, like:
>
> -extern ptid_t target_wait (ptid_t ptid, struct target_waitstatus *status,
> - int options);
> + /* For target_wait see target/target.h. */
>
> -extern int target_write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr,
> - ssize_t len);
> + /* For target_write_memory see target/target.h. */
>
> ?
I can certainly do that. Will include it in the next revision.
Cheers,
Gary
--
http://gbenson.net/