This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Typos in gdb/mi
- From: Vladimir Prus <ghost at cs dot msu dot su>
- To: gdb-patches at sourceware dot org
- Date: Tue, 19 Aug 2014 10:55:38 +0400
- Subject: Re: [PATCH] Typos in gdb/mi
- Authentication-results: sourceware.org; auth=none
- References: <53F1BDFA dot 1090101 at ericsson dot com> <lst13c$ogq$1 at ger dot gmane dot org> <20140818151728 dot GA4841 at adacore dot com>
On 08/18/2014 07:17 PM, Joel Brobecker wrote:
I understand the motivation for making the change, and it does make
the code better; thanks for taking the time!
However, I was burned in past, when such cleanup patches caused merge
problems for any local patches anybody might have. I wonder what
others think?
If it makes the code better, let's push it. It's not the contributor's
fault that other people's as-yet-unpushed patches may or may not collide.
If we have conflicting patches, their authors will just have to adjust,
as we often do when doing collaborative work on the same area of the code.
The question is whether combined price the community will pay for such
adjustment is not greater than any improvements due to fixed typos.
I'd be happy to go with your guidance, as far as GDB goes.
I've looked at the patch, and see nothing wrong. Simon, can you push it for
Andreas?
Thanks,
Volodya