Re: [PATCH] Set breakpoint on the right line

[Yao Qi <yao at codesourcery dot com>]

On 08/12/2014 09:18 AM, Yao Qi wrote:
> In gdb.base/watchpoint-hw-hit-once.exp, test scans source and set
> breakpoint on the line having "break-at-exit",
> 
>   gdb_breakpoint [gdb_get_line_number "break-at-exit"]
> 
> However, in watchpoint-hw-hit-once.c, there are two lines having
> this key word:
> 
>   dummy = 1;	/* Stub to catch break-at-exit after WATCHEE has been hit.  */
>   dummy = 2;	/* break-at-exit */
> 
> so the test sets breakpoint on the first one, while I think it is
> expected to set breakpoint on the second one, as far as I can tell
> from the comments in watchpoint-hw-hit-once.c:
> 
>   /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC
>      already stays on the line PC while entering "step"/"continue".  */
> 
> This patch is to change the source matching pattern so that test
> can correctly set breakpoint on the right line.  This patch fixes
> a fail we found on arm-none-eabi target.  Run it again
> on x86_64-linux, no result changes.
> 
> gdb/testsuite:
> 
> 2014-08-12  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.base/watchpoint-hw-hit-once.exp: Set breakpoint on the
> 	right line.

Ping.  https://sourceware.org/ml/gdb-patches/2014-08/msg00190.html

-- 
Yao (éå)