This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Typos in gdb/mi
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>, Vladimir Prus <ghost at cs dot msu dot su>
- Date: Mon, 18 Aug 2014 11:47:58 -0400
- Subject: Re: [PATCH] Typos in gdb/mi
- Authentication-results: sourceware.org; auth=none
- References: <53F1BDFA dot 1090101 at ericsson dot com> <lst13c$ogq$1 at ger dot gmane dot org> <20140818151728 dot GA4841 at adacore dot com>
On 14-08-18 11:17 AM, Joel Brobecker wrote:
> > I understand the motivation for making the change, and it does make
> > the code better; thanks for taking the time!
> >
> > However, I was burned in past, when such cleanup patches caused merge
> > problems for any local patches anybody might have. I wonder what
> > others think?
>
> If it makes the code better, let's push it. It's not the contributor's
> fault that other people's as-yet-unpushed patches may or may not collide.
> If we have conflicting patches, their authors will just have to adjust,
> as we often do when doing collaborative work on the same area of the code.
> I haven't checked, but we do need to make sure that the contributor
> has a copyright assignment on file or else that the patch fits into
> the obvious/tiny patch rule.
About the copyright assignment, Andreas should be covered by the same paperwork as me. We have a site-wide assignment with the FSF that covers all developers in Ericsson Montreal (or Canada, I am not sure).