This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 00/13] Regset rework preparations part 2


Andreas Arnez wrote:

> Andreas Arnez (13):
>   Rename 'descr' field in regset structure to 'regmap'.
>   regcache: Add functions suitable for regset_supply/collect.
>   S390: Migrate to regcache_supply/collect_regset.
>   AARCH64 Linux: Fill 'collect_regset' in regset structures.
>   ALPHA Linux: Fill 'collect_regset' in regset structures.
>   FRV Linux: Fill 'collect_regset' in regset structures.
>   HPPA Linux: Fill 'collect_regset' in regset structures.
>   M32R Linux: Fill 'collect_regset' in regset structure.
>   NIOS2 Linux: Fill 'collect_regset' in regset structure.
>   SCORE: Fill 'collect_regset' in regset structure.
>   TILEGX Linux: Fill 'collect_regset' in regset structure.
>   M68K Linux: Define regset structures.
>   IA64 Linux: Define regset structures.
> 
>  gdb/aarch64-linux-nat.c  |  38 ++-----
>  gdb/aarch64-linux-tdep.c |  90 ++++-----------
>  gdb/aarch64-linux-tdep.h |  18 ++-
>  gdb/alpha-linux-tdep.c   |  56 ++++++----
>  gdb/frv-linux-tdep.c     | 141 +++++++++---------------
>  gdb/hppa-linux-tdep.c    | 103 ++++++-----------
>  gdb/ia64-linux-tdep.c    |  90 +++++++++++++++
>  gdb/m32r-linux-tdep.c    |  79 +++++++++++---
>  gdb/m68klinux-tdep.c     |  66 +++++++++++
>  gdb/nios2-linux-tdep.c   |  21 +++-
>  gdb/ppc-linux-tdep.c     |   4 +-
>  gdb/regcache.c           |  87 +++++++++++++++
>  gdb/regcache.h           |  45 ++++++++
>  gdb/regset.h             |   7 +-
>  gdb/rs6000-tdep.c        |  12 +-
>  gdb/s390-linux-nat.c     | 177 +++++++++++++-----------------
>  gdb/s390-linux-tdep.c    | 279 ++++++++++-------------------------------------
>  gdb/s390-linux-tdep.h    |  13 +--
>  gdb/score-tdep.c         |  86 +++++++--------
>  gdb/score-tdep.h         |  34 +-----
>  gdb/tilegx-linux-tdep.c  |  34 ++----
>  gdb/tilegx-tdep.h        |   1 +
>  22 files changed, 748 insertions(+), 733 deletions(-)

I've reviewed the full patch set again, and cannot see any further problem.
Also, as far as I can see, all issues pointed out by reviewers on previous
iterations of the patch set have now been addressed.

Therefore, I'm approving the patch set now, so we can make some more progress
on refactoring the regset / core file code.  Thanks for working on this!

Bye,
Ulrich


-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]