This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c


Doug Evans wrote:
> Gary Benson writes:
>  > @@ -35,6 +29,8 @@ static inline void
>  >  linux_debug (const char *format, ...)
>  >  {
>  >  #ifdef GDBSERVER
>  > +  extern int debug_threads;
>  > +
> 
> Recognizing that this is a temporary hack, ok by me.
> Can I ask you to add a FIXME here though?

I added:

  /* FIXME: This conditional code and hacky extern are necessary now,
      but should be removed when GDB's and gdbserver's Linux thread_db
      implementations are unified and moved into the nat directory.  */
  
Thanks,
Gary

-- 
http://gbenson.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]