This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Thu, 7 Aug 2014 13:38:59 +0100
- Subject: Re: [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c
- Authentication-results: sourceware.org; auth=none
- References: <1406888377-25795-1-git-send-email-gbenson at redhat dot com> <1406888377-25795-12-git-send-email-gbenson at redhat dot com> <21474 dot 30047 dot 278277 dot 20526 at ruffy dot mtv dot corp dot google dot com>
Doug Evans wrote:
> Gary Benson writes:
> > @@ -35,6 +29,8 @@ static inline void
> > linux_debug (const char *format, ...)
> > {
> > #ifdef GDBSERVER
> > + extern int debug_threads;
> > +
>
> Recognizing that this is a temporary hack, ok by me.
> Can I ask you to add a FIXME here though?
I added:
/* FIXME: This conditional code and hacky extern are necessary now,
but should be removed when GDB's and gdbserver's Linux thread_db
implementations are unified and moved into the nat directory. */
Thanks,
Gary
--
http://gbenson.net/