This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/11 v5] Introduce common/errors.h
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 6 Aug 2014 09:40:19 -0700
- Subject: Re: [PATCH 01/11 v5] Introduce common/errors.h
- Authentication-results: sourceware.org; auth=none
- References: <1406888377-25795-1-git-send-email-gbenson at redhat dot com> <1406888377-25795-2-git-send-email-gbenson at redhat dot com> <21474 dot 21959 dot 405429 dot 703789 at ruffy dot mtv dot corp dot google dot com> <20140806162940 dot GA14412 at blade dot nx>
On Wed, Aug 6, 2014 at 9:29 AM, Gary Benson <gbenson@redhat.com> wrote:
> Doug Evans wrote:
>> Gary Benson writes:
>> > +#ifdef GDBSERVER
>> > +#include "server.h"
>> > +#else
>> > +#include "defs.h"
>> > +#endif
>> > +#include "errors.h"
>>
>> Nit: The introductory email to this patch series didn't mention
>> this instance of #ifdef GDBSERVER. Needed?
>
> It's removed in patch 8 of the series.
> It's only here to ensure the series builds at every step.
[Sometimes I wonder if we're way too anal in this regard.
There's so much work to do, and we bog ourselves down with such
pedantic administrivia.
Sometimes there's a good reason to have a patch series buildable at each step.
But I think the pendulum is tilted far too much towards the pedantic side.
/$0.02]
No worries though. Thanks for the pointer.