This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Rename variable with confusing name


> I saw this gem of not so legible code in solib-svr4.c (scan_dyntag):
> 
> 	if (dyn_tag == dyntag)
> 
> and thought it deserved a small rename.

Indeed!

> 2014-08-01  Simon Marchi  <simon.marchi@ericsson.com>
> 
> 	* solib-svr4.c (scan_dyntag): Rename dyntag, dyn_tag and
> 	dyn_ptr variables.

Approved, and many thanks for this small but important improvement.
We also have the same issue in scan_dyntag_auxv; if you feel inclined
to it, the same change is pre-approved there.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]