This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Rename variable with confusing name
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 6 Aug 2014 06:17:35 -0700
- Subject: Re: [PATCH] Rename variable with confusing name
- Authentication-results: sourceware.org; auth=none
- References: <1406930946-28195-1-git-send-email-simon dot marchi at ericsson dot com>
> I saw this gem of not so legible code in solib-svr4.c (scan_dyntag):
>
> if (dyn_tag == dyntag)
>
> and thought it deserved a small rename.
Indeed!
> 2014-08-01 Simon Marchi <simon.marchi@ericsson.com>
>
> * solib-svr4.c (scan_dyntag): Rename dyntag, dyn_tag and
> dyn_ptr variables.
Approved, and many thanks for this small but important improvement.
We also have the same issue in scan_dyntag_auxv; if you feel inclined
to it, the same change is pre-approved there.
--
Joel