This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Delete struct inferior_suspend_state
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 31 Jul 2014 14:11:24 -0700
- Subject: Re: [PATCH] Delete struct inferior_suspend_state
- Authentication-results: sourceware.org; auth=none
- References: <yjt2silh73aa dot fsf at ruffy dot mtv dot corp dot google dot com> <20140731193050 dot GA7927 at host2 dot jankratochvil dot net> <CADPb22TPw+9eOv2hna==EomvmNNyATTkqUvwyqKLU7V-L=PAEA at mail dot gmail dot com> <20140731200529 dot GG14672 at adacore dot com> <CADPb22Sb=LMc-2+gXugd+9CMcRR3KmgNRg_Sde2PaTqz8-VkZA at mail dot gmail dot com> <20140731204242 dot GH14672 at adacore dot com> <CADPb22TSKj2HmCfpHKgurARrq1AE5_6Mm4juGXqZ6O2wF1RUyQ at mail dot gmail dot com>
> That's a general concern, yes.
> My comments in this thread are confined to the particular case at hand.
Jan was saying that he does not mind it if the code gets removed.
So I think we can remove it.
Jan also asked that we add a comment to mark the location where
the code should be add should we need it. I don't mind, but
these are about something that has become a fairly general and
standard paradigm, so I don't personally really see much usefulness
in that, while things may change in the future, making those
comments incomplete or incorrect.
Commented-out code should be avoided, and removed if found.
There are no absolute rules as far as I am concerned, so we may
one day face a situation where it's best to ignore that rule.
But we'd have to justify why that's best before going ahead.
In this particular case IMO, the convenience doesn't justify us
keeping the code around, so I would go ahead removing it.
--
Joel