This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] infcmd.c (attach_command): Improve comment.
- From: Doug Evans <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 29 Jul 2014 14:32:49 -0700
- Subject: [PATCH] infcmd.c (attach_command): Improve comment.
- Authentication-results: sourceware.org; auth=none
Hi.
I always have to re-lookup what target_attach_no_wait means,
and what targets set it to non-zero, every time I look at this code.
This patch is a modest attempt at clearing things up for me.
[maybe a good example of why double negatives should be avoided,
in this case "! no-wait". maybe not.]
2014-07-29 Doug Evans <dje@google.com>
* infcmd.c (attach_command): Improve comment.
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index d84c591..1def6cd 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2578,7 +2578,7 @@ attach_command (char *args, int from_tty)
}
/* Some system don't generate traps when attaching to inferior.
- E.g. Mach 3 or GNU hurd. */
+ E.g. Mach 3 or GNU hurd. Skip waiting for these targets. */
if (!target_attach_no_wait)
{
struct inferior *inferior = current_inferior ();