This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Do not include config.h directly


On 07/25/2014 02:34 PM, Gary Benson wrote:
> All source files under gdb/ that include headers from gdb/ include
> either defs.h or server.h before any other code 

> with the exception
> of gdb/gdbserver/gdbreplay.c which seems to be a special case.  

gdbreplay is simply another program that lives in the
gdbserver directory too, for historical reasons.

> Both
> defs.h and server.h include both our and gnulib's config.h files as
> their first non-comment line, so no other file ever needs to directly
> include any config.h.  This commit removes two such direct config.h
> includes.
> 

Looks good.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]