This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/3] config.h rationalization


On 07/25/2014 02:34 PM, Gary Benson wrote:
> I am aware that the first patch in the series creates some redundant
> includes, for example common/ptid.c now includes defs.h or server.h,
> both of which include ptid.h, but I did not remove the "#include ptid.h"
> from ptid.c.

Please don't remove that one.  It's a simpler rule if all .c files
include their corresponding .h file.

> I intend to address these redundant includes as common
> code is migrated into common-defs.h.

-- 
Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]