This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler
- From: Andreas Schwab <schwab at suse dot de>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, gdb-patches at sourceware dot org, "'Andrew Burgess'" <aburgess at broadcom dot com>, "'Doug Evans'" <xdje42 at gmail dot com>, "'Eli Zaretskii'" <eliz at gnu dot org>, "'Florian Weimer'" <fw at deneb dot enyo dot de>, "'Mark Kettenis'" <mark dot kettenis at xs4all dot nl>, "'Pedro Alves'" <palves at redhat dot com>, "'Tom Tromey'" <tromey at redhat dot com>, "'Corinna Vinschen'" <vinschen at redhat dot com>
- Date: Mon, 14 Jul 2014 10:54:21 +0200
- Subject: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140609152229 dot GA27494 at blade dot nx> <20140609152434 dot GD27494 at blade dot nx> <000901cf9eb5$16841da0$438c58e0$ at muller@ics-cnrs.unistra.fr> <20140714085154 dot GA27730 at blade dot nx>
Gary Benson <gbenson@redhat.com> writes:
> diff --git a/gdb/cp-support.c b/gdb/cp-support.c
> index a8ea6fc..6a09b46 100644
> --- a/gdb/cp-support.c
> +++ b/gdb/cp-support.c
> @@ -1557,7 +1557,9 @@ gdb_demangle (const char *name, int options)
> #if defined (HAVE_SIGACTION) && defined (SA_RESTART)
> sa.sa_handler = gdb_demangle_signal_handler;
> sigemptyset (&sa.sa_mask);
> +#ifdef HAVE_SIGALTSTACK
> sa.sa_flags = SA_ONSTACK;
> +#endif
You probably need to initialize sa.sa_flags in any case.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."