This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: gbenson at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Jun 2014 18:06:22 +0200 (CEST)
- Subject: Re: [PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]
- Authentication-results: sourceware.org; auth=none
- References: <1403104976-2492-1-git-send-email-gbenson at redhat dot com>
> From: Gary Benson <gbenson@redhat.com>
> Date: Wed, 18 Jun 2014 16:22:52 +0100
>
> Hi all,
>
> This series continues on from the refactoring series I posted
> yesterday and partially committed today:
>
> 1 - Partially revert 4be83cc2b28ea09aa8ff789839e6520df60836f8
>
> Pedro spotted that i386_{insert,remove}_hw_breakpoint could be
> further refactored. Patch 2 of this series does precisely that.
> This change means a number of functions I made nonstatic do not
> now have to be. This patch reverts that change. I apologise
> for this noise but the end result is better.
>
> 2 - Refactor i386_{insert,remove}_hw_breakpoint
>
> As above.
>
> 3 - Create nat/i386-dregs.c
>
> This patch moves all the code from the various files into
> the new file nat/i386-dregs.c and adds it to the buildsystem.
>
> 4 - Directly call i386-dregs functions
>
> This patch is a small tidyup of i386-nat.c.
>
> Is this ok to commit?
What is the whole point about this excercise?