This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [Patch, microblaze]: Add slr and shr regs
- From: Ajit Kumar Agarwal <ajit dot kumar dot agarwal at xilinx dot com>
- To: Michael Eager <eager at eagerm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Cc: Vinod Kathail <vinodk at xilinx dot com>, Vidhumouli Hunsigida <vidhum at xilinx dot com>, Nagaraju Mekala <nmekala at xilinx dot com>
- Date: Thu, 12 Jun 2014 08:34:09 +0000
- Subject: RE: [Patch, microblaze]: Add slr and shr regs
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=pass (sender IP is 149.199.60.83) smtp dot mailfrom=ajit dot kumar dot agarwal at xilinx dot com;
- References: <c6fe468a-5e02-430a-b34b-73de6bfd2b97 at BY2FFO11FD021 dot protection dot gbl> <537EFA08 dot 1060309 at eagercon dot com> <f0c2c22a-d3d6-45d1-92ba-660dd364fd89 at BL2FFO11FD051 dot protection dot gbl> <537FCEDA dot 9030504 at eagercon dot com> <2e5c185d-329c-46cf-930c-8cc2288891aa at BN1BFFO11FD019 dot protection dot gbl> <538431FB dot 2070904 at eagercon dot com> <865132b2-a593-4147-a7c6-cee25c1ed0fd at BN1AFFO11FD052 dot protection dot gbl> <53909299 dot 9010105 at eagerm dot com> <dab8980c-8551-4ebe-856e-4d8b91d207fe at BN1AFFO11FD059 dot protection dot gbl> <5395FCE6 dot 80702 at eagerm dot com> <ce1fecc8-d1be-4f62-85d3-ddf558c350db at BL2FFO11FD060 dot protection dot gbl> <539613D1 dot 4020808 at eagerm dot com> <c0151d38-382c-4af8-9b97-555ef50e0c0b at BN1AFFO11FD014 dot protection dot gbl> <5397123C dot 7040907 at eagerm dot com> <3a07b07b-b3e1-4030-94f8-da6ee73b9267 at BL2FFO11FD025 dot protection dot gbl> <539723D0 dot 7030505 at eagerm dot com>
Thank you all. All the feedbacks have been incorporated and the fresh patch will be sent in the next mail.
-----Original Message-----
From: Michael Eager [mailto:eager@eagerm.com]
Sent: Tuesday, June 10, 2014 8:57 PM
To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Add slr and shr regs
On 06/10/14 07:49, Ajit Kumar Agarwal wrote:
>
> -----Original Message-----
> From: Michael Eager [mailto:eager@eagerm.com]
> Sent: Tuesday, June 10, 2014 7:42 PM
> To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
> Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
> Subject: Re: [Patch, microblaze]: Add slr and shr regs
>
> On 06/10/14 06:50, Ajit Kumar Agarwal wrote:
>>
>>>> XMD is not running gdbserver built with these sources, is it?
>>
>> Yes XMD is not running gdbserver built with these sources.
>>
>>>> Your patch modified files under gdb/gdbserver. When you build binutils/gdb with -target=microblaze-xilinx-elf, these files are not built.
>>
>> The patch related to building gdbserver with the latest FSF Sources will be the next patch which I am going to submit for review.
>
>>> Changes related to building gdbserver should be submitted together. It sounds like this patch is dependent on some future patch.
>
> Could you please explain why you think building gdbserver should be submitted together?. This patch is related to the problem of Remote G Packet error which is mainly targeted for baremetal.
> Solving the mismatching error between packets returning from XMD Stub and GDB.
Your patch contains changes to gdbserver. As far as you have indicated, you haven't built or tested gdbserver from these sources.
> This is plainly independent of the patch that deals with gdbserver patch which mainly deals with native linux debugging support which is quite independent of this patch.
I have no idea what your future patch will contain.
I don't particularly care whether you submit the gdbserver changes in this patch together with this unknown future patch, or whether you submit them as multiple patches. It appears that these changes are inappropriate for a patch which is unrelated.
>>> Please submit a revised patch which addresses one problem:
>>> support for the added registers in MicroBlaze v8.10a. As mentioned previously, gdb built with this patch should continue to support the same versions of MicroBlaze that are currently supported.
>
> Support for SHR/SHL registers with baremetal support is quite different from the patch with building gdbserver as XMD doesnât use the gdbserver stub from the FSF sources. It has its own gdbserver And we donât have plans to replace gdb Server in XMD with gdbserver from FSF Sources. The building of gdbServer from FSF is mainly related to Linux native debugging and use for Linux image Support of MIcroblaze which is quite independent of the patch submitted for baremetal.
Yes, support for baremetal is quite different from Linux patches.
This patch is only for baremetal support and should not contain changes to gdbserver.
> I donât see any relations between the two and why the patches should be submitted together.
I'm asking you to have one patch address one change.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077