Re: [PATCH] Add Frame.read_register to Python API

[Alexander Smundak <asmundak at google dot com>]

On Mon, Jun 9, 2014 at 12:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> When 2 changes are in the same node, write them one after the other,
> and have only one "(Node Name)" thing.
Done.

>> +* Python Scripting
>> +  Access frame registers
>
> This is an incomplete sentence.  I guess you meant something like
>   You can now access frame registers from Python scripts.
Done.

>> +Return the value of @var{register} in this frame. The @var{register}
>> +argument must be a string (e.g., 'rsp' or 'r1'), or a register number.
>                                     ^^^^^^^^^^^^^
> These should be in @code instead of quotes.
Added the code but retained the quotes, because it's string literal.

>> +Returns @code{Gdb.Value} object.
>           ^
> "a" missing here.
Done.
Here it is again:

The ability to read registers is needed to use Frame Filter API to
display the frames created by JIT compilers.

gdb/Changelog
2014-06-09  Sasha Smundak  <asmundak@google.com>

* python/py-frame.c (frapy_read_register): New function.

2014-06-09  Sasha Smundak  <asmundak@google.com>

* python.texi (Writing a Frame Filter): Fix example code.
(Frames in Python): Fix reference in find_sal description.
Add read_register description.

2014-06-09  Sasha Smundak  <asmundak@google.com>

* gdb.python/py-frame.exp: Test Frame.read_register.

Attachment: frame-read-register-patch-2.txt
Description: Text document