This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add Frame.read_register to Python API


> Date: Mon, 9 Jun 2014 12:15:26 -0700
> From: Alexander Smundak <asmundak@google.com>
> 
> 2014-06-09  Sasha Smundak  <asmundak@google.com>
> 
> * python.texi (Writing a Frame Filter): Fix example code.
> (Frames in Python): Add read_register description.
> (Frames in Python): Fix reference in find_sal description.

When 2 changes are in the same node, write them one after the other,
and have only one "(Node Name)" thing.

> +* Python Scripting
> +  Access frame registers

This is an incomplete sentence.  I guess you meant something like

  You can now access frame registers from Python scripts.

> +Return the value of @var{register} in this frame. The @var{register}
> +argument must be a string (e.g., 'rsp' or 'r1'), or a register number.
                                    ^^^^^^^^^^^^^
These should be in @code instead of quotes.

> +Returns @code{Gdb.Value} object.
          ^
"a" missing here.

The documentation parts are OK with these fixed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]