This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] Don't suppress errors inserting/removing hardware breakpoints in shared libraries.
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 6 Jun 2014 16:58:25 +0800
- Subject: Re: [pushed] Don't suppress errors inserting/removing hardware breakpoints in shared libraries.
- Authentication-results: sourceware.org; auth=none
- References: <1398262082-12503-1-git-send-email-palves at redhat dot com> <538D982A dot 4070404 at codesourcery dot com> <5390946C dot 6010408 at redhat dot com> <539130AC dot 2050401 at codesourcery dot com> <53917E96 dot 1010607 at redhat dot com>
On 06/06/2014 04:40 PM, Pedro Alves wrote:
> On 06/06/2014 04:08 AM, Yao Qi wrote:
>> On 06/06/2014 12:01 AM, Pedro Alves wrote:
>>> Yes, but no need to match by target, we can do like e.g.,
>>> gdb.base/signull.exp does, and check whether "x /b 0" manages
>>> to read memory. If so, then skip the test. Any sane target with
>>> an MMU will leave page 0 unmapped, so no need to look for some other
>>> address.
>>
>> How about the patch below?
>>
>
> OK. Thanks!
>
Thanks for the review. Patch is pushed in.
--
Yao (éå)