This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2 v3] Demangler crash handler
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gbenson at redhat dot com, gdb-patches at sourceware dot org, aburgess at broadcom dot com, fw at deneb dot enyo dot de, mark dot kettenis at xs4all dot nl, palves at redhat dot com, tromey at redhat dot com
- Date: Thu, 05 Jun 2014 05:53:42 +0300
- Subject: Re: [PATCH 2/2 v3] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140604100755 dot GA7570 at blade dot nx> <20140604100957 dot GC7570 at blade dot nx> <834n017z8w dot fsf at gnu dot org> <20140604133603 dot GC10121 at blade dot nx> <83sink7pww dot fsf at gnu dot org> <20140604142844 dot GB11730 at blade dot nx> <CAP9bCMQpqUR=PYJgPyZ-rdhdykJhU31mLgH8raR5dPQnMC9yEw at mail dot gmail dot com> <20140604182529 dot GA14897 at blade dot nx> <CAP9bCMSPY+=fy-2gNcfK-qeiSkDg-0g8BjJnaQeGjcyRkK5V1w at mail dot gmail dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 4 Jun 2014 18:11:16 -0700
> From: Doug Evans <xdje42@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
> Andrew Burgess <aburgess@broadcom.com>, Florian Weimer <fw@deneb.enyo.de>,
> Mark Kettenis <mark.kettenis@xs4all.nl>, Pedro Alves <palves@redhat.com>,
> Tom Tromey <tromey@redhat.com>
>
> One thing that I think should be considered is that we'll go from the
> simple state of "just ifdef every signal" in places like
> common/signals.c to having some signals you are required to not ifdef
> and some you do, and needing to know which category every signal fits
> in. I don't have a strong opinion, but I'm ok with the status quo.
The list of ANSI-standard signals is short, and it's easy to check
which signal is or isn't.
Ifdef's are ugly. Minimizing their use is a Good Thing.