This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4
- From: Pedro Alves <palves at redhat dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Doug Evans <dje at google dot com>, uweigand at de dot ibm dot com
- Date: Wed, 04 Jun 2014 22:06:26 +0100
- Subject: Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gydnP62Od_5iUv1PeCquRSVNNJky31C8ZwTDY3ret8ACQ at mail dot gmail dot com> <538F7A06 dot 4040108 at redhat dot com> <CAGyQ6gzpHfaAeJ1q_Q71Y00K9kLfbEVnb=Y=30cSLaK0RuBv1A at mail dot gmail dot com>
On 06/04/2014 09:53 PM, Siva Chandra wrote:
> On Wed, Jun 4, 2014 at 12:56 PM, Pedro Alves <palves@redhat.com> wrote:
>> How about we handle this in a central place, like Py_DECREF is
>> handled ? See python-internal.h.
>
> This breakage was marked as "nice to have it fixed" for 7.8.
> Considering that, do you prefer that we have a Py_DECREF like solution
> now, or after 7.8 branching?
I think such a solution would be pretty safe. I'd vote just
doing it now and not having to think about it again.
--
Pedro Alves