This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/7.8] user breakpoint not inserted if software-single-step at same location
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, Andreas Schwab <schwab at suse dot de>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Wed, 04 Jun 2014 09:01:32 +0100
- Subject: Re: [RFA/7.8] user breakpoint not inserted if software-single-step at same location
- Authentication-results: sourceware.org; auth=none
- References: <1401394280-14999-1-git-send-email-brobecker at adacore dot com> <5387BFF0 dot 6010208 at redhat dot com> <20140530122253 dot GC4289 at adacore dot com> <53887ED5 dot 5050603 at redhat dot com> <20140530132659 dot GD4289 at adacore dot com> <5388AA76 dot 4070101 at redhat dot com> <538DB721 dot 30308 at codesourcery dot com> <538DB8EC dot 20109 at redhat dot com> <mvmtx82dwf6 dot fsf at hawking dot suse dot de> <538DBD65 dot 5050409 at redhat dot com> <538EAACD dot 8000700 at codesourcery dot com>
On 06/04/2014 06:12 AM, Yao Qi wrote:
> On 06/03/2014 08:19 PM, Pedro Alves wrote:
>> On 06/03/2014 01:12 PM, Andreas Schwab wrote:
>>> Pedro Alves <palves@redhat.com> writes:
>>>
>>>> Ah, thanks. We need to replace then with asm("nop") then.
>>>
>>> nop isn't portable.
>>
>> Yes, but it doesn't matter what the instruction is as
>> long as it's a single instruction that doesn't do much.
>> For archs that don't have "nop" (like e.g., IA64), we can
>> just use #ifdef to pick another insn.
>>
>
> Pedro, here is the patch to tweak sss-bp-on-user-bp.exp.
> I give up on looking for a portable "nop" for various arch. In
> stead, we can use disassemble to get the next instruction address
> and set breakpoint there. See details in the commit log below.
Good idea. Patch is OK.
Thanks!
--
Pedro Alves