This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 21 May 2014 13:34:03 -0400
- Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
- Authentication-results: sourceware.org; auth=none
- References: <1400018204-29559-1-git-send-email-simon dot marchi at ericsson dot com> <87mweh31qi dot fsf at fleche dot redhat dot com>
On Fri 16 May 2014 04:30:45 PM EDT, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> This one was also from a year ago, I would like to make sure it is still
> Simon> OK.
>
> Simon> + if (inferior->has_exit_code)
> Simon> + ui_out_field_string (uiout, "exit-code",
> Simon> + int_string (inferior->exit_code, 8, 0, 0, 1));
>
> Why not the simpler ui_out_field_int?
> Going out of the way to print it in octal seems a bit odd for a machine
> interface.
>
> Tom
Agreed. I found that the exit code is often represented in octal (the
reason for this probably predates my birth). But for MI, it does not
matter.
Simon