This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Import the "dirfd" gnulib module
- From: Gregory Fong <gregory dot 0xf0 at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 15 May 2014 19:37:57 -0700
- Subject: Re: [PATCH] Import the "dirfd" gnulib module
- Authentication-results: sourceware.org; auth=none
- References: <1392676734-737-1-git-send-email-gregory dot 0xf0 at gmail dot com> <87tx8q96cm dot fsf at fleche dot redhat dot com>
On Thu, May 15, 2014 at 12:42 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Gregory" == Gregory Fong <gregory.0xf0@gmail.com> writes:
>
> Gregory> This imports the gnulib dirfd module so that LSB 3.0 can be targeted
> Gregory> when building gdb with the LSB SDK. It doesn't make any other changes
> Gregory> to gdb.
>
> I'm sorry nobody reviewed your patch earlier.
>
> I think importing the dirfd module is probably fine, but I confess I
> don't really understand the rationale. I'm going to guess that dirfd
> isn't in LSB 3.0 but gnulib works around this ... ?
Yes, that's correct. I posted a more thorough explanation earlier at
https://sourceware.org/ml/gdb/2014-02/msg00034.html
Best regards,
Gregory