This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4][REPOST] Remote Linux ptrace exec events
- From: Yao Qi <yao at codesourcery dot com>
- To: Don Breazeal <donb at codesourcery dot com>, <gdb-patches at sourceware dot org>
- Cc: Don Breazeal <don_breazeal at relay1 dot mentorg dot com>
- Date: Thu, 8 May 2014 13:41:42 +0800
- Subject: Re: [PATCH 2/4][REPOST] Remote Linux ptrace exec events
- Authentication-results: sourceware.org; auth=none
- References: <1398885482-8449-1-git-send-email-donb at codesourcery dot com> <1398885482-8449-3-git-send-email-donb at codesourcery dot com>
I don't have much based on Luis's comments. Two nits on changelog:
On 05/01/2014 03:18 AM, Don Breazeal wrote:
> gdbserver/
> 2014-04-02 Don Breazeal <donb@codesourcery.com>
>
> * gdb/gdbserver/linux-low.c (linux_child_pid_to_exec_file): New
^^^^^^^^^^^^^
There is a ChangeLog file in gdb/gdbserver directory, so don't need to
have "gdb/gdbserver/" in file name. "* linux-low.c (...." should be fine.
> function.
> (handle_extended_wait): Add support for PTRACE_EVENT_EXEC.
> (check_zombie_leaders): Update comment.
> (linux_low_filter_event): Add support for PTRACE_EVENT_EXEC.
> (linux_wait_for_event_filtered): Update comment.
> (extended_event_reported): New function.
> (send_sigstop): Delete lwp on 'No such process' error and
> reset current_inferior.
> * gdb/gdbserver/linux-low.h (struct lwp_info): New member
> 'waitstatus'.
We document new member with angle brackets, like
* linux-low.h (struct lwp_info) <waitstatus>: New member.
--
Yao (éå)