This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info
- From: David Blaikie <dblaikie at gmail dot com>
- To: Doug Evans <dje at google dot com>, Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 24 Apr 2014 20:23:52 -0700
- Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info
- Authentication-results: sourceware.org; auth=none
- References: <CAENS6EtFF4hPJe3uqJBkPf4q8c0n4RvV1_jO=6mWWEp=X2HbnA at mail dot gmail dot com> <21336 dot 14486 dot 650610 dot 274638 at ruffy dot mtv dot corp dot google dot com>
On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans <dje@google.com> wrote:
> David Blaikie writes:
> > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a
> > bunch of GDB tests that rely on debug info for labels.
> >
> > For some reason gdb.linespec/ls-expr.exp gathered all tests into a
> > dictionary and then ran them. This made it hard to XFAIL just the
> > right tests. I refactored this to execute the tests directly, removing
> > the dictionary so I could XFAIL the right tests. Is there a reason it
> > would've been written that way? Does my patch break it in some way?
> > commit c438cb16b63292e415330f289616c4e4ecece63c
> > Author: David Blaikie <dblaikie@gmail.com>
> > Date: Sun Apr 13 11:42:02 2014 -0700
> >
> > XFAIL under Clang tests using labels
> >
> > gdb/testsuite/
> > * gdb.base/label.exp: XFAIL label related tests under Clang.
> > * gdb.cp/cplabel.exp: Ditto.
> > * gdb.linespec/ls-errs.exp: Refactor tests to execute directly
> > and XFAIL under Clang those using labels.
>
> LGTM
>
> > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog
> > index 730c116..b04b940 100644
> > --- gdb/testsuite/ChangeLog
> > +++ gdb/testsuite/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2014-04-12 David Blaikie <dblaikie@gmail.com>
> > +
> > + * gdb.base/label.exp: XFAIL label related tests under Clang.
> > + * gdb.cp/cplabel.exp: Ditto.
> > + * gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels.
> > +
>
> Nit: space vs tabs. Just use tabs.
> Plus line is longer than 80 chars.
Thanks for the catches - fixed those up and committed in
c2e827ad5340fcf1735df6c77cb0311e56b985ef.
Also refactored some of the xfails along the lines of what Pedro
suggested in the one test case that had several similar failures
(gdb.base/label.exp). If/when we fix this in Clang it might be worth
refactoring into a common function (though I'm personally not very
vested in keeping the test suite usable with anything other than ToT
Clang - perhaps others are).