This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2
- From: Andy Wingo <wingo at igalia dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 Apr 2014 11:04:15 +0200
- Subject: Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2
- Authentication-results: sourceware.org; auth=none
- References: <1397060028-18158-1-git-send-email-wingo at igalia dot com> <1397060028-18158-2-git-send-email-wingo at igalia dot com> <m3eh12tsag dot fsf at sspiff dot org>
Hi,
Thanks for the review. I'll post a new patchset shortly incorporating
feedback. Sorry for the gaffe with the changelogs.
On Sat 12 Apr 2014 18:40, Doug Evans <xdje42@gmail.com> writes:
> 2) The change to configure is small, so it's not a big a deal,
> but, for reference sake, the convention here is to not include changes
> to machine generated files in patches submitted to the list.
> Plus I wouldn't expect a change to the Copyright year in configure.
I edited the file manually as I don't have autoconf2.64 on my system,
hence the copyright year update. I removed the copyright update from
the updated patchset, but kept the change to the generated configure
file as it's so trivial that I can only imagine autoconf producing
exactly those changes. I can repost that patch without that change if
you like.
> btw, this patch is small enough to not require one, and while I wouldn't
> doubt that you have a copyright assignment for Guile changes :-), do you
> have one for gdb? I can imagine having a blanket assignment for
> everything, just checking.
I was agnozing over having to do that when I found to my pleasant
surprise that Igalia already has a corporate assignment for GDB, made
when Sanjoy Das was doing the custom debug info JIT interface stuff a
couple years ago. Hopefully that suffices.
Cheers,
Andy