This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp
- From: David Blaikie <dblaikie at gmail dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Eric Christopher <echristo at gmail dot com>
- Date: Fri, 11 Apr 2014 17:40:12 -0700
- Subject: Re: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp
- Authentication-results: sourceware.org; auth=none
- References: <CAENS6EsUSQTajixKzmStvX9KrG-8SaTA=YVO=6MFMpY35Um9FQ at mail dot gmail dot com> <CADPb22Q02WZGHif_tLv1vZRA48MhXjGY+ZUdhvNUryODf=5qxw at mail dot gmail dot com>
On Fri, Apr 11, 2014 at 5:18 PM, Doug Evans <dje@google.com> wrote:
> On Fri, Apr 11, 2014 at 4:58 PM, David Blaikie <dblaikie@gmail.com> wrote:
>> This test is intending to use gnu style inline rather than the
>> standard c99 inline semantics. Clang defaults to c99 and the test
>> breaks for this (and other - there's an inlining debug info quality
>> bug here too - I'll file a bug and kfail the remaining failures in a
>> separate patch) reason.
>
> LGTM, but add a comment in the code explaining why the gnu89 is there.
Thanks. Added a comment and committed in
f180a1fb463a6a9ab4a883374120d16770486914.