This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Kyle McMartin <kmcmarti at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 24 Mar 2014 18:00:47 +0000
- Subject: Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures
- Authentication-results: sourceware.org; auth=none
- References: <20140324161056 dot GB23291 at redacted dot bos dot redhat dot com> <20140324165733 dot GN4282 at adacore dot com>
On 24/03/14 16:57, Joel Brobecker wrote:
> Hello Kyle,
>> + /* look for a conditional branch to set a breakpoint on the destination. */
>
> This line looks too long?
Also, comments are full sentences, so begin with a capital letter and
end with a full stop and two spaces.
>> + /* and the matching store-exclusive to close it. */
>> + if (decode_masked_match(insn, 0x3fc00000, 0x08000000))
>
> Same here...
If you really need a continuation comment like this, then end the
previous one with "..." and start the current one with "... and".
Otherwise, this should be re-written as a stand-alone sentence.