This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] btrace: avoid symbol lookup
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Pedro Alves (palves at redhat dot com)" <palves at redhat dot com>
- Date: Fri, 21 Mar 2014 18:22:15 +0100
- Subject: Re: [PATCH 2/2] btrace: avoid symbol lookup
- Authentication-results: sourceware.org; auth=none
- References: <1394182665-14164-1-git-send-email-markus dot t dot metzger at intel dot com> <1394182665-14164-3-git-send-email-markus dot t dot metzger at intel dot com> <20140310214252 dot GA3105 at host2 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B230AA8BFE3 at IRSMSX104 dot ger dot corp dot intel dot com>
On Tue, 11 Mar 2014 11:08:43 +0100, Metzger, Markus T wrote:
> What's missing is a "fast fail", i.e. quickly determine that we won't find any
> symbol for this PC. I won't be able to do this in a reasonable amount of time,
> though, so I thought this patch is a compromise between functionality and
> performance.
I do not think providing incorrect behavior for performance reasons is a valid
tradeoff. The right way would be to fix the DWARF lookups to be fast enough.
But I no longer approve GDB patches so this is just my personal opinion.
Jan