This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC v5 1/8] fix latent bugs in ui-out.c
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Mar 2014 19:16:33 +0000
- Subject: Re: [RFC v5 1/8] fix latent bugs in ui-out.c
- Authentication-results: sourceware.org; auth=none
- References: <1393957974-4521-1-git-send-email-tromey at redhat dot com> <1393957974-4521-2-git-send-email-tromey at redhat dot com>
Hi,
On 03/04/2014 06:32 PM, Tom Tromey wrote:
> The destructor code in ui-out.c has a latent bug, which is hidden by
> the fact that nothing uses this right now. This patch fixes the
> problem. The bug is that we don't always clear a pointer in the
> ui-out object, leading to a bad free.
>
> 2013-10-30 Tom Tromey <tromey@redhat.com>
>
> * ui-out.c (clear_table, ui_out_new): Clear uiout->table.id.
This one is obviously correct. There's really no need
to hold it further, so I went ahead and pushed it in.
Thanks,
--
Pedro Alves