This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
ping: [PATCH] Fix PR16508
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Wed, 5 Mar 2014 10:06:20 +0800
- Subject: ping: [PATCH] Fix PR16508
- Authentication-results: sourceware.org; auth=none
- References: <1392447370-22318-1-git-send-email-yao at codesourcery dot com>
On 02/15/2014 02:56 PM, Yao Qi wrote:
> This patch fixes PR16508, which is about MI "-trace-find frame-number 0"
> behaves differently from CLI "tfind 0". In CLI, we check both
> status->running and status->filename, but in MI, we only check
> status->running, which looks wrong to me. This patch moves the code
> of checking to a new function check_trace_running, and use it in
> both CLI and MI.
>
> This patch also adds a test case pr16508.exp, which fails without this
> fix, and passes with the fix applied.
>
> FAIL: gdb.trace/pr16508.exp: interpreter-exec mi "-trace-find frame-number 0"
>
> Patch is regression tested on x86_64-linux.
>
> gdb:
>
> 2014-02-15 Yao Qi <yao@codesourcery.com>
>
> PR breakpoints/16508
> * tracepoint.c (check_trace_running): New function.
> (trace_find_command): Move code to check_trace_running and
> call check_trace_running.
> (trace_find_pc_command): Likewise.
> (trace_find_tracepoint_command): Likewise.
> (trace_find_line_command): Likewise.
> (trace_find_range_command): Likewise.
> * tracepoint.h (check_trace_running): Likewise.
> * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.
>
> gdb/testsuite:
>
> 2014-02-15 Yao Qi <yao@codesourcery.com>
>
> * gdb.trace/pr16508.exp: New file.
Ping. https://sourceware.org/ml/gdb-patches/2014-02/msg00508.html
--
Yao (éå)