This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN
- From: Yao Qi <yao at codesourcery dot com>
- To: Hui Zhu <hui_zhu at mentor dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Tue, 4 Mar 2014 09:36:11 +0800
- Subject: Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN
- Authentication-results: sourceware.org; auth=none
- References: <530CBCED dot 3000200 at mentor dot com> <53152341 dot 8060501 at codesourcery dot com> <531529CB dot 2020400 at mentor dot com>
On 03/04/2014 09:18 AM, Hui Zhu wrote:
> I cannot understand about this OB is not right. I have 2 questions to you:
> 1. Before my patch, does target-delegates.c that generated by make-target-delegates is same with current target-delegates.c?
No, as I said, I forgot to re-generate target-delegates.c.
> 2. Does this new target-delegates.c that generated by make-target-delegates can be built success?
No, we should use TARGET_DEFAULT_NORETURN instead of
TARGET_DEFAULT_RETURN, which is a mistake when I resolved conflicts.
struct traceframe_info *(*to_traceframe_info) (struct target_ops *)
TARGET_DEFAULT_NORETURN (tcomplain ());
--
Yao (éå)